Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new nonce instead of current nonce #97

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

adlerjohn
Copy link
Member

Fixes #96

@adlerjohn adlerjohn added bug Something isn't working contracts labels Mar 24, 2022
@adlerjohn adlerjohn self-assigned this Mar 24, 2022
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Doesn't this need a test ? Checking if the correct checkpoint is being created ?

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🙏

@adlerjohn
Copy link
Member Author

@sweexordious #98

@adlerjohn adlerjohn merged commit cc05609 into master Mar 24, 2022
@adlerjohn adlerjohn deleted the adlerjohn/fix-nonce branch March 24, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contracts
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use the correct nonce when updating the validator set
3 participants